这个程序错在哪里?

synn

要求只修改类DEPART,其它不能修改,兄弟们帮帮手

2. #include <iostream.h>
3. #include <string.h>
5. const int CODE_LEN=8;
6. const int NAME_LEN=40;
9. class DEPART{
10. public:
11.    DEPART()
12.    {
13.      code=new char[CODE_LEN+1];
14.      strcpy(code,"");
15.      name=new char[NAME_LEN+1];
16.      strcpy(name,"");
17.      cout<<"D_\n";
18.      return;
19.    }
20.    DEPART(char* dep_code,char* dep_name)
21.    {
22.      int len;
25.      len=strlen(dep_code);
26.      code=new char[len+1];
27.      strncpy(code,dep_code,len);  code[len]='\0';
28.      len=strlen(dep_name);
29.      name=new char[len+1];
30.      strncpy(name,dep_name,len);  name[len]='\0';
31.      cout<<"D\n";
32.      return;
33.      }
34.      ~DEPART()
35.    {
36.      delete code;
37.      delete name;
38.      cout<<"~D\n";
39.      return;
40.    }
41.    void print()
42.    {
43.      cout<<"Department code is "<<code<<",name is "<<name<<".\n";
44.      return;
45.    }
46. private:
47.    char* code;
48.    char* name;
49. };
52. class EMPLOYEE{
53. public:
54.    EMPLOYEE()
55.    {
56.      code=new char[CODE_LEN+1];
57.      strcpy(code,"");
58.      name=new char[NAME_LEN+1];
59.      strcpy(name,"");
60.      cout<<"E_\n";
61.      return;
62.    }
63.    EMPLOYEE(char* wrk_code,char* wrk_name)
64.    {
65.      int len;
68.      len=strlen(wrk_code);
69.      code=new char[len+1];
70.      strncpy(code,wrk_code,len);  code [len]='\0';
71.      len=strlen(wrk_name);
72.      name=new char[len+1];
73.      strncpy(name,wrk_name,len);  name [len]='\0';
74.      cout<<"E\n";
75.      return;
76.    }
77.    ~EMPLOYEE()
78.    {
79.      delete code;
80.      delete name;
81.      cout<<"~E\n";
82.      return;
83.    }
84.    void set_depart(DEPART depart)
85.    {
86.      EMPLOYEE::depart=depart;
87.      return;
88.    }
89.    DEPART get_depart()
90.    {
91.      return depart;
92.    }
93.    void print()
94.    {
95.      cout<<"Employee code is "<<code<<",name is "<<name<<".He belongs to:\n";
96.      depart.print();
97.      return;
98.    }
99. private:
100.    char* code;
101.    char* name;
102.    DEPART depart;
103. };
106. int main()
107. {
108.    DEPART dep("01","Shipment Department");
109.    EMPLOYEE emp("LB","Liu Bing");
112.    emp.set_depart(dep);
113.    emp.print();
114.    dep=emp.get_depart();
115.    dep.print();
116.    return 0;
117. }

复制代码

libinary

应该给DEPART类提供复制构造函数和赋值运算符，加上这两个成员就好了

0100

下次应该注意代码的缩进。

麥頭

楼主也应该看看vb码说明（斑竹签名）。
代码没有宿进，
你的类。没有use std::cout等
delete用delete []？
private 放在前面好些

synn

对不起,我已把缩进改正过来了.
以下是我在~DEPART()前面加进的的代码,但编译不了.

2.   DEPART(DEPART& obj)
3.   {
4.     int len;
5.     len=strlen(obj.code);
6.     code=new char[len+1];
7.     strncpy(code,obj.code,len); code[len]='\0';
8.     len=strlen(obj.name);
9.     name=new char[len+1];
10.     strncpy(name,obj.name,len); name[len]='\0';
11.     //cout<<"&D\n";
12.     return;
13.   }
14.   DEPART operator =(DEPART& obj)
15.   {
16.     int len;
17.     len=strlen(obj.code);
18.     code=new char[len+1];
19.     strncpy(code,obj.code,len); code[len]='\0';
20.     len=strlen(obj.name);
21.     name=new char[len+1];
22.     strncpy(name,obj.name,len); name[len]='\0';
23.     //cout<<"=D\n";
24.     return;
25.     }

复制代码

libinary

怎么编译不了，什么错误？
把：
#include <iostream.h>
#include <string.h>
改成：
#include <iostream>
#include <string>
using namespace std;
试试。

libinary

还有，麥頭说的，应该用delete[]。
类里只要涉及到成员分配内存，就应该提供构造函数、复制构造函数、赋值运算符、析构函数，你的EMPLOYEE类也不完全。

synn

因为题目是约定了只能修改DEPART类的.
我把程序改成了这样,还是通过不了

2. #include <iostream>
3. #include <string>
5. using namespace std;
7. const int CODE_LEN=8;
8. const int NAME_LEN=40;
10. class DEPART{
11. public:
12.   DEPART()
13.   {
14.     code=new char[CODE_LEN+1];
15.     strcpy(code,"");
16.     name=new char[NAME_LEN+1];
17.     strcpy(name,"");
18.     //cout<<"D_\n";
19.     return;
20.   }
21.   DEPART(char* dep_code,char* dep_name)
22.   {
23.     int len;
25.     len=strlen(dep_code);
26.     code=new char[len+1];
27.     strncpy(code,dep_code,len);  code[len]='\0';
28.     len=strlen(dep_name);
29.     name=new char[len+1];
30.     strncpy(name,dep_name,len);  name[len]='\0';
31.     //cout<<"D\n";
32.     return;
33.     }
34.   DEPART(DEPART& obj)
35.   {
36.     int len;
37.     len=strlen(obj.code);
38.     code=new char[len+1];
39.     strncpy(code,obj.code,len); code[len]='\0';
40.     len=strlen(obj.name);
41.     name=new char[len+1];
42.     strncpy(name,obj.name,len); name[len]='\0';
43.     //cout<<"&D\n";
44.     return;
45.   }
46.   DEPART operator =(DEPART& obj)
47.   {
48.     int len;
49.     len=strlen(obj.code);
50.     code=new char[len+1];
51.     strncpy(code,obj.code,len); code[len]='\0';
52.     len=strlen(obj.name);
53.     name=new char[len+1];
54.     strncpy(name,obj.name,len); name[len]='\0';
55.     //cout<<"=D\n";
56.     return;
57.     }
58.   ~DEPART()
59.   {
60.     delete[] code;
61.     delete[] name;
62.     //cout<<"~D\n";
63.     return;
64.   }
65.   void print()
66.   {
67.     cout<<"Department code is "<<code<<",name is "<<name<<".\n";
68.     return;
69.   }
70. private:
71.   char* code;
72.   char* name;
73. };
75. class EMPLOYEE{
76. public:
77.   EMPLOYEE()
78.   {
79.     code=new char[CODE_LEN+1];
80.     strcpy(code,"");
81.     name=new char[NAME_LEN+1];
82.     strcpy(name,"");
83.     //cout<<"E_\n";
84.     return;
85.   }
86.   EMPLOYEE(char* wrk_code,char* wrk_name)
87.   {
88.     int len;
90.     len=strlen(wrk_code);
91.     code=new char[len+1];
92.     strncpy(code,wrk_code,len);  code [len]='\0';
93.     len=strlen(wrk_name);
94.     name=new char[len+1];
95.     strncpy(name,wrk_name,len);  name [len]='\0';
96.     //cout<<"E\n";
97.     return;
98.   }
99.   ~EMPLOYEE()
100.   {
101.     delete code;
102.     delete name;
103.     //cout<<"~E\n";
104.     return;
105.   }
106.   void set_depart(DEPART depart)
107.   {
108.     EMPLOYEE::depart=depart;
109.     return;
110.   }
111.   DEPART get_depart()
112.   {
113.     return depart;
114.   }
115.   void print()
116.   {
117.     cout<<"Employee code is "<<code<<",name is "<<name<<".He belongs to:\n";
118.     depart.print();
119.     return;
120.   }
121. private:
122.   char* code;
123.   char* name;
124.   DEPART depart;
125. };
127. int main()
128. {
129.   DEPART dep("01","Shipment Department");
130.   EMPLOYEE emp("LB","Liu Bing");
132.   emp.set_depart(dep);
133.   emp.print();
134.   dep=emp.get_depart();
135.   dep.print();
136.   return 0;
137. }

复制代码

提示错误是:
8-7.cpp: In member function `DEPART DEPART:perator=(DEPART&)':
8-7.cpp:55: return-statement with no value, in function declared with a
   non-void return type
8-7.cpp: In function `int main()':
8-7.cpp:133: no match for `DEPART& = DEPART' operator
8-7.cpp:46: candidates are: DEPART DEPART:perator=(DEPART&)

麥頭

[修改如下：
g++
注意构造函数没有return；
operator (const depart&)

1. 
   
2. #include <iostream>
   
3. #include <string>
   
4. 
   
5. using namespace std;
   
6. 
   
7. const int CODE_LEN=8;
   
8. const int NAME_LEN=40;
   
9. 
   
10. class DEPART{
    
11. private:
    
12.   char* code;
    
13.   char* name;
    
14. public:
    
15.   DEPART()
    
16.   {
    
17.     code=new char[CODE_LEN+1];
    
18.     strcpy(code,"");
    
19.     name=new char[NAME_LEN+1];
    
20.     strcpy(name,"");
    
21.     //cout<<"D_\n";
    
22.   }
    
23.   DEPART(char* dep_code,char* dep_name)
    
24.   {
    
25.     int len;
    
26. 
    
27.     len=strlen(dep_code);
    
28.     code=new char[len+1];
    
29.     strncpy(code,dep_code,len);  code[len]='\0';
    
30.     len=strlen(dep_name);
    
31.     name=new char[len+1];
    
32.     strncpy(name,dep_name,len);  name[len]='\0';
    
33.     //cout<<"D\n";
    
34.     }
    
35.   DEPART(const DEPART& obj)
    
36.   {
    
37.     int len;
    
38.     len=strlen(obj.code);
    
39.     code=new char[len+1];
    
40.     strncpy(code,obj.code,len);
    
41.     code[len]='\0';
    
42.     len=strlen(obj.name);
    
43.     name=new char[len+1];
    
44.     strncpy(name,obj.name,len);
    
45.     name[len]='\0';
    
46.     //cout<<"&D\n";
    
47.    }
    
48.   DEPART &operator=(const DEPART& obj)
    
49.   {
    
50.     int len;
    
51.     len=strlen(obj.code);
    
52.     code=new char[len+1];
    
53.     strncpy(code,obj.code,len); code[len]='\0';
    
54.     len=strlen(obj.name);
    
55.     name=new char[len+1];
    
56.     strncpy(name,obj.name,len); name[len]='\0';
    
57.     //cout<<"=D\n";
    
58.     return *this;
    
59.     }
    
60.   ~DEPART()
    
61.   {
    
62.     delete[] code;
    
63.     delete[] name;
    
64.     //cout<<"~D\n";
    
65.   }
    
66.   void print()
    
67.   {
    
68.     cout<<"Department code is "<<code<<",name is "<<name<<".\n";
    
69.     return;
    
70.   }
    
71. };
    
72. 
    
73. class EMPLOYEE{
    
74. private:
    
75.   char* code;
    
76.   char* name;
    
77.   DEPART depart;
    
78. public:
    
79.   EMPLOYEE()
    
80.   {
    
81.   
    
82.     code=new char[CODE_LEN+1];
    
83.     strcpy(code,"");
    
84.     name=new char[NAME_LEN+1];
    
85.     strcpy(name,"");
    
86.     //cout<<"E_\n";
    
87.   }
    
88.   EMPLOYEE(char* wrk_code,char* wrk_name)
    
89.   {
    
90.     int len;
    
91. 
    
92.     len=strlen(wrk_code);
    
93.     code=new char[len+1];
    
94.     strncpy(code,wrk_code,len);  code [len]='\0';
    
95.     len=strlen(wrk_name);
    
96.     name=new char[len+1];
    
97.     strncpy(name,wrk_name,len);  name [len]='\0';
    
98.     //cout<<"E\n";
    
99.   }
    
100.   ~EMPLOYEE()
     
101.   {
     
102.   
     
103.     delete code;
     
104.     delete name;
     
105.     //cout<<"~E\n";
     
106.   }
     
107.   void set_depart(DEPART &depart)
     
108.   {
     
109.     EMPLOYEE::depart=depart;
     
110.     return;
     
111.   }
     
112.   DEPART get_depart()
     
113.   {
     
114.     return depart;
     
115.   }
     
116.   void print()
     
117.   {
     
118.     cout<<"Employee code is "<<code<<",name is "<<name<<".He belongs to:\n";
     
119.     depart.print();
     
120.     return;
     
121.   }
     
122. 
     
123. };
     
124. 
     
125. int main()
     
126. {
     
127.   DEPART dep("01","Shipment Department");
     
128.   EMPLOYEE emp("LB","Liu Bing");
     
129. 
     
130.   emp.set_depart(dep);
     
131.   emp.print();
     
132.   dep=(emp.get_depart());
     
133.   dep.print();
     
134.   return 0;
     
135. }
     

复制代码

运行：
root@localhost c++_file]# a.out
Employee code is LB,name is Liu Bing.He belongs to:
Department code is 01,name is Shipment Department.
Department code is 01,name is Shipment Department.
[root@localhost c++_file]#

libinary

麥頭的函数形式正确，不过代码还有一点问题，在复制构造函数和赋值运算符里首先应该判断传入的对象不是本对象，&obj != this，虽然给自己赋值不经常出现，但还是应该避免错误。